Skip to content

fix: Traceback now provides block_id which caused the error#603

Merged
surajshetty3416 merged 3 commits into
frappe:developfrom
stravo1:better-error-tracing
May 20, 2026
Merged

fix: Traceback now provides block_id which caused the error#603
surajshetty3416 merged 3 commits into
frappe:developfrom
stravo1:better-error-tracing

Conversation

@stravo1
Copy link
Copy Markdown
Member

@stravo1 stravo1 commented May 19, 2026

It was very difficult to track which block caused an error. We now pass block_id to the filename parameter of execute_script function to help traceback the block which is the source of the error.

Screenshot 2026-05-19 at 8 40 21 AM Screenshot 2026-05-19 at 8 39 54 AM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.82%. Comparing base (6d56d17) to head (e5d54af).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #603      +/-   ##
===========================================
+ Coverage    57.63%   57.82%   +0.18%     
===========================================
  Files           29       29              
  Lines         3194     3206      +12     
===========================================
+ Hits          1841     1854      +13     
+ Misses        1353     1352       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stravo1 stravo1 requested a review from surajshetty3416 May 19, 2026 03:39
Copy link
Copy Markdown
Member

@surajshetty3416 surajshetty3416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stravo1 Add a simple test case for this?

@stravo1 stravo1 requested a review from surajshetty3416 May 19, 2026 17:45
@surajshetty3416 surajshetty3416 merged commit b9b1b5d into frappe:develop May 20, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants