Conversation
|
| valueFrom: | ||
| secretKeyRef: | ||
| key: postgresql-password | ||
| key: postgres-password |
There was a problem hiding this comment.
Missing PostgreSQL regression coverage
Both PostgreSQL site-creation jobs should be rendered in tests and checked for secretKeyRef.key: postgres-password. Current CI exercises only the single-site MariaDB branch, so this typo could recur undetected. This violates the repository requirement that bug fixes include regression coverage and must be addressed before merging.
Context Used: Guidelines for reviewing Frappe Framework applications. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: erpnext/templates/job-create-site.yaml
Line: 157
Comment:
**Missing PostgreSQL regression coverage**
Both PostgreSQL site-creation jobs should be rendered in tests and checked for `secretKeyRef.key: postgres-password`. Current CI exercises only the single-site MariaDB branch, so this typo could recur undetected. This violates the repository requirement that bug fixes include regression coverage and must be addressed before merging.
**Context Used:** Guidelines for reviewing Frappe Framework applications. ([source](https://github.com/frappe/skills/blob/main/skills/quality-code-review/SKILL.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing a typo in the postgres sercet key for Stateful postgres version:
The generated secret in my k8s is;
Note that this secret creates
postgres-passwordinstead ofpostgresql-password