This repository was archived by the owner on Sep 25, 2019. It is now read-only.
feat(scripts): stop caching challenges and improve build scripts#179
Open
ojeytonwilliams wants to merge 1 commit intofreeCodeCamp:devfrom
Open
feat(scripts): stop caching challenges and improve build scripts#179ojeytonwilliams wants to merge 1 commit intofreeCodeCamp:devfrom
ojeytonwilliams wants to merge 1 commit intofreeCodeCamp:devfrom
Conversation
raisedadead
added
the
status: ready for QA
Member
|
Hi @ojeytonwilliams can we get this rebased against the latest |
ojeytonwilliams
force-pushed
the
fix/challenge-caching
branch
from
8af8061 to
058a9d6
Compare
Contributor
Author
|
Apparently I'm an idiot and didn't save... let me see if I can fix this. |
Avoid caching challenges so that changes can be hotloaded into Gatsby. Add scripts to watch challenges and atomically copy them to the dist directory, without minification. ISSUES CLOSED: freeCodeCamp#68
ojeytonwilliams
force-pushed
the
fix/challenge-caching
branch
from
058a9d6 to
ffe7634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid caching challenges so that changes can be hotloaded into Gatsby. Add scripts to watch
challenges and atomically copy them to the dist directory, without minification.
ISSUES CLOSED: #68
Description
Unfortunately linting changed a fair bit of the original. My main changes are to add some build scripts, some gulp tasks and use
fsto read the challenge json, rather thanrequirePre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Closes #68