Skip to content

Fix scoped external-search shortcuts - #2729

Merged
simon04 merged 1 commit into
freeCodeCamp:mainfrom
dajiaohuang:fix/2728-scoped-external-search
Sep 13, 2026
Merged

simon04 merged 1 commit into
freeCodeCamp:mainfrom
dajiaohuang:fix/2728-scoped-external-search

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Fixes #2728

Scoped external-search shortcuts threw before opening the provider when a documentation name was included. This makes the local mutable and adds a regression test for the scoped URL.

Tests:

  • node --test test/assets/search_hash_test.js
  • node --check on all 78 non-vendored JavaScript files

The Ruby suite was not run because Ruby/Bundler are unavailable in the audit environment.

@dajiaohuang
dajiaohuang requested a review from a team as a code owner September 8, 2026 11:50

@simon04 simon04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very much appreciated!

@simon04
simon04 merged commit 24a328e into freeCodeCamp:main Sep 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scoped external-search shortcuts throw before opening provider

2 participants