Simplify the font stacks to what modern browsers need - #2736
Merged
Merged
Conversation
system-ui always resolves, so every family between it and sans-serif was unreachable as a primary font: -apple-system is redundant with system-ui since Safari 11, BlinkMacSystemFont only mattered for Chrome <56, and 'San Francisco' was never a valid installed family name. The rest are just what system-ui already picks per platform. The monospace stack can't collapse the same way -- ui-monospace is Safari-only and the generic monospace resolves to Courier New in Firefox on Windows -- but it can lose 'SF Mono', which isn't reliably exposed to web content under that name, and Courier, which the generic covers. Menlo now precedes Consolas so a Mac with MS Office installed keeps Menlo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system-ui always resolves, so every family between it and sans-serif
was unreachable as a primary font: -apple-system is redundant with
system-ui since Safari 11, BlinkMacSystemFont only mattered for
Chrome <56, and 'San Francisco' was never a valid installed family
name. The rest are just what system-ui already picks per platform.
The monospace stack can't collapse the same way -- ui-monospace is
Safari-only and the generic monospace resolves to Courier New in
Firefox on Windows -- but it can lose 'SF Mono', which isn't reliably
exposed to web content under that name, and Courier, which the generic
covers. Menlo now precedes Consolas so a Mac with MS Office installed
keeps Menlo.