Skip to content

upgrade to node24 #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dloetzke merged 2 commits into from
Apr 13, 2026
Merged

upgrade to node24 #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8c2b71
SPOC-945202: upgrade to node 24
aabeling Apr 9, 2026
7ea3018
SPOC-945202: upgrade undici
aabeling Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.20
24
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ inputs:
description: 'Version of GitHub CLI'
default: '2.76.0'
runs:
using: 'node20'
using: 'node24'
main: 'dist/index.js'
98 changes: 47 additions & 51 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop

@lkreimann lkreimann Apr 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wir erhöhen hier in der Package.json immer die Version (müsste eine neue Major-Version sein), weil das auch gleichzeitig immer die Version der Action ist, die dann genutzt werden kann

Müsste auch in der README noch geändert werden - können wir aber im Zweifel auch machen

Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@
"@actions/core": "1.11.1",
"@actions/tool-cache": "2.0.2"
},
"overrides": {
"undici": "6.24.0"
},
"devDependencies": {
"@stylistic/eslint-plugin": "5.10.0",
"@types/jest": "30.0.0",
"@types/node": "20.19.35",
"@types/node": "^24.12.2",

@lkreimann lkreimann Apr 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@types/node": "^24.12.2",
"@types/node": "24.12.2",

"@typescript-eslint/parser": "8.57.2",
"@vercel/ncc": "0.38.4",
"eslint": "9.39.3",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "es6",
"target": "es2022",
"module": "commonjs",
"outDir": "./lib",
"rootDir": "./src",
Expand Down
Loading