Split StreamMicrogridDispatches into HostDispatch API#351
Open
Marenz wants to merge 2 commits into
Open
Conversation
Remove the controller-facing StreamMicrogridDispatches RPC and its request/response messages from the public Dispatch API. The stream operation (and future status reporting) now live in the new frequenz-api-hostdispatch repo (frequenz-io, private). This is the first step of the three-repo split: - frequenz-api-dispatch-common (shared types, public) - frequenz-api-dispatch (cloud CRUD, public, this repo) - frequenz-api-hostdispatch (controller ops, private) See frequenz-floss#350 for the full split plan. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
requested review from
stefan-brus-frequenz
and removed request for
a team
github-actions
Bot
added
part:docs
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Contributor
|
What are we gaining by removing streaming from this API? It is a breaking change, what's the improvement here? |
Contributor
Author
|
Streaming is controller-only and no public client uses it - Kuiper proxy and the etrading actor are both CRUD-only. Removing it just keeps the public API honest. But it's a breaking change for no functional gain, so I'm happy to keep it in the public API too - worth discussing whether the tidier surface is worth the break. |
Contributor
|
We can deprecate it to make it clear the intention is to remove it in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the controller-facing
StreamMicrogridDispatchesRPC and its request/response messages from the public Dispatch API.frequenz-api-dispatch-common— shared message types (to be created)frequenz-api-dispatch— cloud/app-facing CRUD operations (this repo)Note: The shared message types (
Dispatch,DispatchData,RecurrenceRule,TargetComponents, etc.) remain in this repo for now and will be moved tofrequenz-api-dispatch-commonin a follow-up PR once that repo is published.