Rename symbols for better consistency#218
Merged
Merged
Conversation
Rename the generic component union alias so it carries the same `Electrical` prefix as its sibling aliases and keep the converter imports sorted. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Rename the wrapper-facing connection endpoints while keeping the protobuf field reads and local converter variables unchanged. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Rename the wrapper-facing lifetime attributes to use the `_time` suffix while keeping protobuf timestamp reads unchanged and updating validation, helpers, and tests. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Adopt the `_time` wrapper naming convention while keeping the converter pointed at the protobuf `create_timestamp` field. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Record the field naming and docstring rules in CONTRIBUTING.md as the source of truth and point the code-pattern guide to it. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
ela-kotulska-frequenz
and removed request for
a team
llucax
added
the
cmd:skip-release-notes
github-actions
Bot
added
part:docs
tiyash-basu-frequenz
approved these changes
Jun 16, 2026
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jun 16, 2026
f019eaf
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComponentTypestoElectricalComponentTypessource/destinationto*_idLifetime.start/endtostart_time/end_timeMicrogrid.create_timestamptocreate_timeAlso document the naming conventions hoping it helps keeping consistency in the future.
Part of #203.