Skip to content

fix: make setstatus() accept label as first argument #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
friendly-bits merged 2 commits into from
Sep 7, 2026
Merged

fix: make setstatus() accept label as first argument #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53482fb
fix: make setstatus() accept label as first argument
binomnom Sep 5, 2026
2c57e56
Update setstatus comment to match nomenclature.
binomnom Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions lib/geoip-shell-lib-config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,16 +469,17 @@ getstatus() {
}

# wrapper for setconfig()
# 1: path to file
# 1: type
# 2: path to file
# args are passed as is to setconfig
setstatus() {
[ "$1" ] || { bad_args setstatus "$@"; die; }
[ -d "${1%/*}" ] || mkdir -p "${1%/*}" || return 1
# [ "$ROOT_OK" = 1 ] && chmod -R 600 "${1%/*}"
# [ -f "$1" ] || touch "$1" &&
# [ "$ROOT_OK" = 1 ] && chmod 600 "$1"
[ "$1" ] && [ "$2" ] || { bad_args setstatus "$@"; die; }
[ -d "${2%/*}" ] || mkdir -p "${2%/*}" || return 1
# [ "$ROOT_OK" = 1 ] && chmod -R 600 "${2%/*}"
# [ -f "$2" ] || touch "$2" &&
# [ "$ROOT_OK" = 1 ] && chmod 600 "$2"
setconfig "$@" && return 0
rm -f "$1"
rm -f "$2"
return 1
}

Expand Down