Repository navigation
fix(deploy): 部署 workflow 加上守門，網頁加 meta CSP - #128
Merged
Merged
Conversation
- 部署手冊 2.4：checkout 加 persist-credentials: false；緊急手動發布流程發布前檢查 owner 與 main。harbor-release 由 Harbor App 觸發，執行者不是 owner，維持原本的輸入驗證與 environment，不加 owner 檢查。 - CI 加入 npm audit，high／critical 或稽核失敗都讓 CI 失敗。 - 部署手冊 2.2：index.html 加 meta CSP，只允許本站、Harbor 維護腳本與 Google Fonts。 驗證：npm audit --audit-level=high 通過；VITE_BASE=/software-engineering-workshop/ npm run build:pages 後用 Chromium 開首頁與 4 個分頁，CSP 違規 0 筆；模擬 Harbor 維護中與正常兩種回應都正常。本機 test:e2e 有 3 個 navigation 測試失敗，拿掉這次修改在 main 上也同樣失敗（沙箱環境因素），以 CI 結果為準。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
依 Harbor 部署手冊 2.2、2.4 調整。
修改
persist-credentials: false；緊急手動發布流程（deploy-pages.yml）發布前檢查 owner 與 main。harbor-release.yml由 Harbor App 觸發、執行者不是 owner，維持原本的輸入驗證與 environment，不加 owner 檢查。npm audit --audit-level=high。frontend/index.html加 meta CSP，只允許本站、Harbor 維護腳本與 Google Fonts。驗證
npm audit --audit-level=high通過。VITE_BASE=/software-engineering-workshop/ npm run build:pages後用 Chromium 開首頁與 4 個分頁：CSP 違規 0 筆；模擬 Harbor 維護中與正常兩種回應都正常。test:e2e有 3 個 navigation 測試失敗；拿掉這次修改在 main 上也同樣失敗（沙箱環境因素），以這個 PR 的 CI 結果為準。Rollback
revert 這個 PR。
Generated by Claude Code