Skip to content

fix(react-native): cancel prior iOS Combine sinks before re-subscribing (FR-25940) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dianaKhortiuk-frontegg wants to merge 1 commit into from
Closed

fix(react-native): cancel prior iOS Combine sinks before re-subscribing (FR-25940) #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ios/FronteggRN.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,16 @@ class FronteggRN: RCTEventEmitter {
}
@objc
func subscribe() -> [AnyHashable : Any]! {


// FR-25940: cancel any prior subscriptions before re-subscribing. Each FronteggWrapper mount
// calls subscribe(), and without clearing, the two sinks below accumulated on `cancellables`
// on every call and were never cancelled (stopObserving only flips a flag) — so every state
// change fired N× duplicate native work. Mirrors Android, which disposes before re-subscribing.
cancellables.forEach { $0.cancel() }
cancellables.removeAll()

let auth = fronteggApp.auth

var stateChange: AnyPublisher<Void, Never> {
return Publishers.Merge5 (
auth.$refreshingToken.map { _ in },
Expand Down
Loading