FR-26617: pass the extended venv switch from the calling workflow - #120
Open
yaronblum-frontegg wants to merge 4 commits into
Open
FR-26617: pass the extended venv switch from the calling workflow#120yaronblum-frontegg wants to merge 4 commits into
yaronblum-frontegg wants to merge 4 commits into
Conversation
The mcp-gateway and custom-code applications ship disabled in the venv chart. The venv-builder overrides that per environment, but only if the switch reaches it, so both entrypoints that compose venv files now forward it. Both default to false: a caller that says nothing gets the same venv it gets today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The suite is the one caller that needs the gateway, so it is the one caller that asks for it. Every other caller keeps the venv it has today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Matches the builder input: callers name the applications they want raised rather than carrying a boolean per service. The AI agent suite asks for mcp-gateway; every other caller passes nothing and gets the venv it has today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
yaronblum-frontegg
changed the title
Callers ask for the extended venv, not for named services: the builder holds the list of applications the switch covers. The AI agent suite asks for it, every other caller passes nothing and gets the venv it has today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
yaronblum-frontegg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mcp-gatewayandcustom-codeare about to land in the venv chart switched off (frontegg/venv#118, frontegg/venv#120). The venv-builder can override that per environment (frontegg/venv-actions#200), but only if the request reaches it — and nothing in this repository forwards one.What
An
extendedswitch on both entrypoints that compose venv files (start-venv.yaml,build-docker-start-venv.yaml), forwarded throughshared-actions/start-venvto the builder action. It defaults to false.Callers ask for the extended venv rather than for named services: the builder holds the list of applications the switch covers, so adding a third one later is a line in its registry and no change here. Today the list is
mcp-gatewayandcustom-code, and the switch raises both together.Then one caller opts in: the AI agent suite passes
extended: true.Effect on existing callers
None.
dashboard-test-suite,full-test-suite,run-api-tests,run-api-tests-no-venv,run-e2e-tests,run-e2e-tests-no-venvandtest-docker-pocpass nothing, so the builder writes both applicationsdisabled: true. Renderingcharts/venv-v2against a values file generated by the compiled builder gives 43 Applications either way — byte-identical to the chart's own defaults apart from subdomain substitution.Merge order
This must merge after frontegg/venv-actions#200, frontegg/venv#118 and frontegg/venv#120.
action.ymldoes not declareextended: GitHub warns about an unexpected input and the switch does nothing.repoURL, which ArgoCD rejects. Reproduced withhelm template.Running the AI agent suite from this branch before #200 merges also fails, since
start-venv.yaml@masterwill not yet accept the input.Jira: https://frontegg.atlassian.net/browse/FR-26617