Skip to content

Remove ParseConfig#329

Merged
bartelink merged 2 commits into
masterfrom
copilot/remove-parseconfig-logic
Jun 10, 2026
Merged

Remove ParseConfig#329
bartelink merged 2 commits into
masterfrom
copilot/remove-parseconfig-logic

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Removing ParseConfig per #307 (comment)

@bartelink bartelink marked this pull request as ready for review June 10, 2026 07:45
Copilot AI review requested due to automatic review settings June 10, 2026 07:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the previously documented ArgumentParser.Parse(ParseConfig) API surface from Argu, along with its associated tests, and updates the changelog to no longer mention the feature.

Changes:

  • Remove ParseConfig record type and ArgumentParser<'T>.Parse(ParseConfig) overload.
  • Delete ParseConfigTests.fs and remove it from the test project compilation list.
  • Remove the corresponding ArgumentParser.Parse(ParseConfig) entry from RELEASE_NOTES.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/Argu.Tests/ParseConfigTests.fs Removes tests that exercised the ParseConfig-based parsing API.
tests/Argu.Tests/Argu.Tests.fsproj Stops compiling the removed ParseConfigTests.fs file.
src/Argu/ArgumentParser.fs Removes the ParseConfig type and Parse(ParseConfig) overload from the public API.
RELEASE_NOTES.md Removes the release-note bullet that referenced ArgumentParser.Parse(ParseConfig).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Argu/ArgumentParser.fs
Comment thread RELEASE_NOTES.md
@bartelink bartelink merged commit 8dcad5b into master Jun 10, 2026
9 checks passed
@bartelink bartelink deleted the copilot/remove-parseconfig-logic branch June 10, 2026 07:49
bartelink pushed a commit to dimension-zero/Argu that referenced this pull request Jun 10, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@bartelink bartelink changed the title Remove ParseConfig release-note reference Remove ParseConfig Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants