[repo-assist] Fix Fable CI build: unpin Microsoft.Bcl.AsyncInterfaces version - #335
Open
github-actions[bot] wants to merge 2 commits into
Open
[repo-assist] Fix Fable CI build: unpin Microsoft.Bcl.AsyncInterfaces version#335github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
Microsoft.Bcl.AsyncInterfaces was pinned to 10.0.7 while System.Threading.Channels resolved to a newer transitive dependency (10.0.11), causing a NU1605 package downgrade error. This made Fable's MSBuild-based project cracker fail with an unhandled exception during 'dotnet fable', breaking CI. Fixes #334. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was created by Repo Assist, an automated AI assistant, in response to
/repo-assist Try to fix this pleaseon issue #334.Root Cause
FSharp.Control.AsyncSeq.fsprojpinnedMicrosoft.Bcl.AsyncInterfacesto an exact version (10.0.7), whileSystem.Threading.Channels(referenced withVersion="*") resolved to10.0.11, which transitively requiresMicrosoft.Bcl.AsyncInterfaces >= 10.0.11. This created aNU1605package-downgrade warning during restore.Fable's
dotnet fablecommand uses MSBuild's design-time build to "crack" the project and resolve compiler args. WhenNU1605warnings are present, Fable's project cracker (ProjectCracker.fs) throws an unhandledSystem.Exception, aborting the wholedotnet fableinvocation — this is what broke CI (Test Fablestep inpull-request.yml).Fix
Changed the
Microsoft.Bcl.AsyncInterfacespackage reference from a pinned10.0.7toVersion="*"(matching the existing pattern used forSystem.Threading.Channels), so both packages resolve to their latest compatible versions without conflicting.Trade-offs
Version="*"means the package version isn't locked, matching the existing convention already used forSystem.Threading.Channelsin this project. This keeps consistency rather than introducing stricter pinning.Test Status
✅ Build succeeded:
dotnet test -c Release— 476/476 tests passed, 0 failures.✅ Fable tests now pass:
cd tests/fable && npm i && npm test— 78/78 tests passed (previously failed with an unhandledNU1605-triggered exception duringdotnet fable).Add this agentic workflow to your repo
To install this agentic workflow, run