[repo-assist] perf: avoid allOf double-isEmpty + Array.IndexOf in CallAsync; add V3 schema tests (+5 tests, 438→443)

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Three improvements across Tasks 8 (Performance) and 10 (Take Repository Forward).

Performance: cache Seq.isEmpty allOf in DefinitionCompiler (Task 8)

In compileBySchema, the allOf sequence was evaluated with Seq.isEmpty twice — once for schemaObjProperties and once for schemaObjRequired. Each call iterates up to the first element. The result is now cached in allOfEmpty and reused:

// Before (two Seq.isEmpty calls)
match Seq.isEmpty allOf with | false -> ... | true -> ...  // for properties
match Seq.isEmpty allOf with | false -> ... | true -> ...  // for required

// After (one cached call)
let allOfEmpty = Seq.isEmpty allOf
if allOfEmpty then ... else ...  // properties
if allOfEmpty then ... else ...  // required

Performance: Array.IndexOf in CallAsync (Task 8)

ProvidedApiClientBase.CallAsync used Array.tryFindIndex((=) codeStr), which allocates a partial-application closure on every non-success HTTP response. Replaced with System.Array.IndexOf, which avoids the closure:

// Before
match errorCodes |> Array.tryFindIndex((=) codeStr) with
| Some idx -> ...
| None -> ...

// After
let errorIdx = System.Array.IndexOf(errorCodes, codeStr)
if errorIdx >= 0 then ... else ...

New V3 schema compilation tests (Task 10)

Added 5 tests to Schema.V3SchemaCompilationTests.fs covering previously untested compiler behaviour:

Test	What it covers
required property compiles to non-option type	required: [id] → int32
optional property compiles to option type	omitted from required → string option
string enum schema compiles to a named enum type	type: string, enum: [...] → type named Status
string enum type is an enum	compiled type has IsEnum = true
object schema description is surfaced as XmlDoc	description field → XmlDoc attribute

Test Status

Total: 443, Errors: 0, Failed: 0, Skipped: 1, Time: 1.036s

438 → 443 (+5 new tests). Build: 0 errors, 209 warnings (pre-existing).

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@dcdf09723d42ef9b6c75335e4612fd145d4ccdaa

[Copilot]

Pull request overview

This PR targets small performance improvements in runtime error handling and design-time schema compilation, and expands OpenAPI v3 schema compilation test coverage to validate required/optional property typing, string-enum generation, and XmlDoc emission.

Changes:

• Cache Seq.isEmpty allOf in DefinitionCompiler.compileBySchema to avoid double enumeration.
• Replace Array.tryFindIndex ((=) codeStr) with System.Array.IndexOf in ProvidedApiClientBase.CallAsync to avoid per-call closure allocation on error responses.
• Add 5 OpenAPI v3 schema compilation tests covering required vs optional property typing, string enum generation, and schema description → XmlDoc.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/SwaggerProvider.Tests/Schema.V3SchemaCompilationTests.fs	Adds 5 new unit tests for v3 schema compilation behavior (required/optional properties, string enums, XmlDoc).
src/SwaggerProvider.Runtime/ProvidedApiClientBase.fs	Optimizes error-code lookup in CallAsync using System.Array.IndexOf.
src/SwaggerProvider.DesignTime/DefinitionCompiler.fs	Avoids repeated Seq.isEmpty allOf checks by caching the result during object type compilation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.