Allow passing an :env option to set the environment on the Port transport#34
Open
probably-not wants to merge 6 commits intoftes:mainfrom
Open
Allow passing an :env option to set the environment on the Port transport#34probably-not wants to merge 6 commits intoftes:mainfrom
:env option to set the environment on the Port transport#34probably-not wants to merge 6 commits intoftes:mainfrom
Conversation
ftes
approved these changes
Apr 20, 2026
Owner
ftes
left a comment
ftes
left a comment
There was a problem hiding this comment.
Looks wonderful. Some small suggestions.
ftes
reviewed
Apr 20, 2026
Contributor
Author
|
Applied your suggestions and I removed that duplicated Just let me know your preference on the charlists/strings thing, other than that should be good to go! |
probably-not
force-pushed
the
allow-passing-environment
branch
from
1df73d3 to
8353ca1
Compare
Contributor
Author
|
Huh, strange, my rebase via the GitHub UI lost all of the commit signatures... that's weird... I had it configured to verify web commits. Strange. I'll try and fix that. |
Co-authored-by: Fredrik Teschke <f@ftes.de>
Co-authored-by: Fredrik Teschke <f@ftes.de>
probably-not
force-pushed
the
allow-passing-environment
branch
from
8353ca1 to
dd3557f
Compare
Contributor
Author
|
Alright, there we go! It should be good to go now 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port transport currently does not allow setting the environment, meaning that we can't set any environment variables for Playwright to use. For example, if we want to change the downloaded browser cache to scope it to a specific folder, we need to set the
PLAYWRIGHT_BROWSERS_PATHto the directory where they are downloaded (docs here).This allows passing an
:envoption to the supervisor on startup and ensures that we can pass an explicit environment to the Port transport.