This repository was archived by the owner on Apr 23, 2020. It is now read-only.
added colors for circle and triangle as well as trianglePosition - #3
Open
Zefau wants to merge 13 commits into
Open
added colors for circle and triangle as well as trianglePosition#3Zefau wants to merge 13 commits into
Zefau wants to merge 13 commits into
Conversation
added paddingBottom because last box gets cut off a bit
Owner
|
Thank you for the PR! Do you have any timeline when you want or need an updated version? |
Author
|
Hi ftes. Thanks for the quick reply. The pr is not in rush. |
ftes
suggested changes
Aug 4, 2019
ftes
left a comment
ftes
left a comment
Owner
There was a problem hiding this comment.
When running the example, I see broken inconsistent placing of even and odd (left/right) elements. Can you reproduce this?
| color | black | ||
| twoSidedOverlap | 80 | negative overlap between items if two-sided | ||
| animations | true | ||
| animationScrollDelay | 100 | Delays triggering the animation when scrolling up or down |
Owner
There was a problem hiding this comment.
The wording leaves it unclear if this a time-based or offset/space-based delay.
From the code I see that this is an offset delay of 100px, I think it should
- be mentioned in the description
- possibly added to the variable name.
| const rect = this.children.getBoundingClientRect() | ||
| const vwHeight = window.innerHeight || document.documentElement.clientHeight | ||
| let vwHeight = window.innerHeight || document.documentElement.clientHeight | ||
| let viewTop = window.pageYOffset > vwHeight ? vwHeight : vwHeight - this.props.config.animationScrollDelay |
Owner
There was a problem hiding this comment.
Indentation inconsistent. Should add auto code formatting check for PRs.
| + evenItemOffset | ||
| const offsetEvenNml = offsetEven + itemWidth | ||
| const offsetEvenMed = offsetEven + itemWidthMed | ||
| const offsetOddNml = circleWidth / 2 + paddingToItem + triangleWidth; |
| base: { | ||
| position: 'absolute', | ||
| bottom: '0', | ||
| top: `${ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
thanks for your work.
I added the possibilities to have different colors on circles, lines and triangle. Additionally, I added an option to have the triangle either on top of the box or the bottom of it.
Furthermore, I added an offset for the pop-in effect of the boxes to be delayed.
Cheers,
Zefau