Open
Conversation
mlagergren
commented
Jul 25, 2024
| result = {} | ||
| entities = options.get('selection', []) | ||
| if not entities: | ||
| raise PluginExecutionError('No entities selected!') |
Contributor
Author
There was a problem hiding this comment.
Consider removing the exlamation mark (!) and just use a dot: "No entities selected."
Git gives a bit more of a formal tone in the error messages.
Contributor
There was a problem hiding this comment.
Yes, sorry I didn't saw it when reviewing the code. Changed now.
…ations into backlog/framework-loader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP do not merge
Resolves :
This PR has been tested on :
Overview
Purpose: Ftrack framework loader to be able to load components directly from the ftrack interface to the DCC.
Scope:
Implementation Details
Approach: Based on having one single session and one single event manager that allows users to decide wether they want to run a specifc event in remote or in local mode. That provide us the ability for the client to subscribe to ftrack default remote events like action_discover and action_launch.
subscribe_action_tool) to subscribe to the action events for a specific toolReasoning:
Changes:
Trade-offs:
Testing
Tests Added:
Manual Testing: Its very hard to manually test this PR alone. I have created the following branch to test it on maya with all the needed dependencies.
experimental/test-loaderDon't worry about testing this, we need to first decide if the implementation is the way we want it to be. Then we will test this in the DCC specifc PRs.
Testing Environment:
Notes for Reviewers
Focus Areas:
Dependencies: Highly dependant on:
Known Issues: