refactor(etf): remove code query param from etf-holdings - #10
Merged
Conversation
Server-side removed the optional `code` filter param from GET /v1.0/stock/ownership/etf-holdings/:symbol. Drop it from the SDK's advertised params interface and update the test accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wfv3Xw3onZwDEEZQ5dvRZr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
對齊 server-side MR !376，移除
GET /v1.0/stock/ownership/etf-holdings/:symbol的選填codequery param。這是 #8（新增 ETF endpoint）的 follow-up。#8 已 merge 進
release/v1.5.0但尚未 release，趁 release 前把code拿掉，使用者不會看到帶code的版本。為什麼移除
Server MR !376 已移除該 param（命名不一致、功能雞肋、cache key 膨脹）。移除後仍是 soft degrade：server 未開 whitelist，舊呼叫帶
?code=不會報錯，只是拿回未過濾的完整清單。需過濾單一成分股時，client 端一行 filtercomponents即可。變更內容
src/rest/stock/ownership/etf-holdings.ts：移除 params interface 的code?: string;test/rest-client.spec.ts：測試移除code，URL 斷言同步更新測試
jest：92 passed🤖 Generated with Claude Code