api: add gps device capture to records schema by sjperaltas · Pull Request #75 · fulcrumapp/api

sjperaltas · 2026-06-22T18:54:13Z

What?

Add gps_device_capture to Records v2 response schemas
Add a reusable GpsDeviceCapture response schema with read-only geometry_matches_capture
Add a writable GpsDeviceCaptureRequest schema for record create/update requests

Why?

Documents the backend GPS device capture contract for FLCRM-20532
Prevents downstream schema validation failures caused by the new response shape
Keeps writable input separate from the server-computed geometry_matches_capture field

Related PRs:

https://github.com/fulcrumapp/fulcrum/pull/10928

Resolution

Updated Record and RecordHistoryItem to include gps_device_capture
Updated RecordRequest and RecordPatchRequest to accept gps_device_capture
Modeled geometry_matches_capture as a response-only boolean inside the response schema

Code Review

High quality code reviews are expected. You can utilize this PR review checklist to help you conduct one.

Testing

Validated reference/rest-api.json parses as valid JSON
Ran npx --yes rdme openapi validate rest-api.json successfully
Checked for RAW_BODY anti-patterns
Reviewed the diff to confirm only the Records-related schemas changed

Copilot

Pull request overview

This PR updates the OpenAPI specification (reference/rest-api.json) to document the new gps_device_capture shape on Records v2 responses and to accept corresponding input on record create/update requests, aligning the published schema with the backend contract for FLCRM-20532.

Changes:

Add gps_device_capture to the Record and RecordHistoryItem response schemas.
Introduce reusable GpsDeviceCapture (response) and GpsDeviceCaptureRequest (write) schemas, with geometry_matches_capture modeled as response-only (readOnly).
Extend RecordRequest and RecordPatchRequest to accept gps_device_capture via GpsDeviceCaptureRequest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

sjperaltas · 2026-07-24T00:17:14Z

/retest

Copilot AI review requested due to automatic review settings June 22, 2026 18:54

sjperaltas requested review from a team as code owners June 22, 2026 18:54

Copilot started reviewing on behalf of sjperaltas June 22, 2026 18:54 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json Outdated

Comment thread reference/rest-api.json Outdated

Copilot AI review requested due to automatic review settings July 22, 2026 20:44

sjperaltas and others added 2 commits July 22, 2026 14:46

Add gps_device_capture to records schema

7b81a2f

Refactor GPS device capture OpenAPI schemas

93c637c

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

sjperaltas force-pushed the feature/FLCRM-20532-gps-device-capture-api-openapi branch from b8709f1 to 93c637c Compare July 22, 2026 20:46

Document gps_device_capture response fields

2b185d8

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json Outdated

Comment thread reference/rest-api.json Outdated

Comment thread reference/rest-api.json Outdated

Copilot AI review requested due to automatic review settings July 22, 2026 21:01

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Clarify GPS capture request schema contract

ad9ab9c

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 22, 2026 22:02

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json Outdated

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

KaraFox reviewed Jul 22, 2026

View reviewed changes

Comment thread reference/rest-api.json Outdated

Copilot AI review requested due to automatic review settings July 23, 2026 14:30

sjperaltas force-pushed the feature/FLCRM-20532-gps-device-capture-api-openapi branch from 15fe4f2 to d1c2473 Compare July 23, 2026 14:31

sjperaltas requested a review from KaraFox July 23, 2026 14:35

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Copilot AI review requested due to automatic review settings July 23, 2026 14:48

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

Remove geometry_matches_capture from API schema

28ac3b7

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 23, 2026 15:13

sjperaltas force-pushed the feature/FLCRM-20532-gps-device-capture-api-openapi branch from d1c2473 to 28ac3b7 Compare July 23, 2026 15:13

KaraFox approved these changes Jul 23, 2026

View reviewed changes

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread reference/rest-api.json

Comment thread reference/rest-api.json

jacobpayne659 approved these changes Jul 24, 2026

View reviewed changes

KaraFox merged commit 400b859 into v2 Jul 24, 2026
4 of 5 checks passed

KaraFox deleted the feature/FLCRM-20532-gps-device-capture-api-openapi branch July 24, 2026 21:52

Uh oh!

Conversation

sjperaltas commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

Resolution

Code Review

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sjperaltas commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sjperaltas commented Jun 22, 2026 •

edited

Loading