Skip to content

fix: handle clipboard copy failures gracefully #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejvasek merged 1 commit into from
Jun 16, 2026
+44 −0
Merged

fix: handle clipboard copy failures gracefully #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/claude-progress.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
# Claude Progress Log
# Newest entries first. Agents: append your entry at the top after the header.

---
## 2026-06-12 | Session: Fix clipboard copy error handling
Worked on: Add error state for copy-to-clipboard buttons on landing page
Completed:
- Added error handling for navigator.clipboard API unavailability (e.g. non-HTTPS contexts)
- Added .catch() handler for clipboard.writeText promise rejection
- Added error state styling (.copy-error class) with red color, X icon, and "Copy failed" hover label
- Applied error handling to both install command and YAML copy buttons
Left off: Branch pr/fix-catch ready for review.
Blockers: None

---
## 2026-05-21 | Session: Page co-location restructure (continued)
Worked on: Follow-up fixes from review, test cleanup, docs
Expand Down
11 changes: 11 additions & 0 deletions docs/features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,5 +180,16 @@
"All tests pass, no broken imports"
],
"passes": true
},
{
"category": "technical",
"description": "Landing page: copy buttons handle clipboard failures gracefully (non-HTTPS, permission denied)",
"steps": [
"Pre-check navigator.clipboard availability before calling writeText",
"Catch writeText rejections (e.g. permission denied, iframe sandbox)",
"Error state shows X icon with 'Copy failed' label on hover, auto-clears after 1.5s",
"Both copy buttons (install command and YAML) have error handling"
],
"passes": true
}
]
22 changes: 22 additions & 0 deletions pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@
position: absolute;
top: 0.6rem;
right: 0.6rem;
display: inline-flex;
align-items: center;
gap: 0.3rem;
background: transparent;
border: none;
color: #484f58;
Expand All @@ -160,10 +163,16 @@
}
.copy-btn:hover { color: #8b949e; background: rgba(255, 255, 255, 0.06); }
.copy-btn.copied { color: var(--accent); }
.copy-btn.copy-error { color: #f85149; }
.copy-icon { width: 16px; height: 16px; }
.check-icon { width: 16px; height: 16px; display: none; }
.error-icon { width: 16px; height: 16px; display: none; }
.error-label { display: none; font-family: 'JetBrains Mono', monospace; font-size: 0.65rem; }
.copy-btn.copied .copy-icon { display: none; }
.copy-btn.copied .check-icon { display: inline; }
.copy-btn.copy-error .copy-icon { display: none; }
.copy-btn.copy-error .error-icon { display: inline; }
.copy-btn.copy-error:hover .error-label { display: inline; }
.fade-in { animation: fadeIn 0.6s ease both; }
.fade-in-delay-1 { animation-delay: 0.1s; }
.fade-in-delay-2 { animation-delay: 0.2s; }
Expand All @@ -188,6 +197,8 @@ <h5 class="card-title">Install</h5>
<button class="copy-btn" data-target="install-cmd" data-strip="$ ">
<svg class="copy-icon" viewBox="0 0 16 16" fill="currentColor"><path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"/><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"/></svg>
<svg class="check-icon" viewBox="0 0 16 16" fill="currentColor"><path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"/></svg>
<svg class="error-icon" viewBox="0 0 16 16" fill="currentColor"><path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"/></svg>
<span class="error-label">Copy failed</span>
</button>
<pre><code id="install-cmd"><span class="prompt">$</span> oc new-project console-functions-plugin
<span class="prompt">$</span> oc apply -f https://functions-dev.github.io/ocp-console-plugin/plugin.yaml</code></pre>
Expand All @@ -209,6 +220,8 @@ <h5 class="card-title">plugin.yaml</h5>
<button class="copy-btn" data-target="yaml-content">
<svg class="copy-icon" viewBox="0 0 16 16" fill="currentColor"><path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"/><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"/></svg>
<svg class="check-icon" viewBox="0 0 16 16" fill="currentColor"><path d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"/></svg>
<svg class="error-icon" viewBox="0 0 16 16" fill="currentColor"><path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"/></svg>
<span class="error-label">Copy failed</span>
</button>
<div class="yaml-scroll">
<pre><code id="yaml-content">Loading...</code></pre>
Expand All @@ -227,9 +240,18 @@ <h5 class="card-title">plugin.yaml</h5>
if (strip) {
text = text.split('\n').map(l => l.startsWith(strip) ? l.slice(strip.length) : l).join('\n');
}
// Clipboard API requires a secure context (HTTPS). On plain HTTP, navigator.clipboard might be undefined.
if (typeof navigator.clipboard === 'undefined') {

@twoGiants twoGiants Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief comment why this block was added? Thx 👍

btn.classList.add('copy-error');
setTimeout(() => { btn.classList.remove('copy-error'); }, 1500);
return;
}
navigator.clipboard.writeText(text).then(() => {
btn.classList.add('copied');
setTimeout(() => { btn.classList.remove('copied'); }, 1500);
}).catch(() => {
btn.classList.add('copy-error');
setTimeout(() => { btn.classList.remove('copy-error'); }, 1500);
});
});
});
Expand Down
Loading