feat: add local GitHub Pages dev support #36
Conversation
|
After spending some time with local dev setup on CRC, I'm rethinking the very simple approach of separate command. I see it needs to be properly wired into local dev loop. |
dsimansk
changed the title
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Nice, going into the right direction! I'd just move it to the init script. See my comments below.
| @@ -55,7 +55,9 @@ Available image tags are listed in the [container registry](https://github.com/f | |||
| In one terminal window, run: | |||
There was a problem hiding this comment.
Can you update the entire Option 1 (rename to Setup) section to say that init.sh should be used to start the dev env?
A few more things:
- Remove the sections:
#### Running start-console with Apple silicon and podmanOption 2: ...
- Add a small section in the Readme telling how to view the github pages locally.
- Add
goandhelmto the prerequisites. - You could make the
plugin.yamlgeneration optional in theinit.shscript, thengoandhelmwill also be optional.
There was a problem hiding this comment.
@twoGiants I've updated the readme, but it's a bit of overhaul. Could you pls check if it make sense to you.
I'd still wrap ./init.sh into some yarn alias like yarn dev, wdyt?
There was a problem hiding this comment.
Readme looks great! Thank you for the update.
I'd leave it because we have also init --stop|--randomize-ports or the init usage will be fragmented.
dsimansk
changed the title
init.sh now generates plugin.yaml (via helm template) and copies pages/index.html into backend/static/ so the running Go backend serves the landing page locally. Also adds helm prerequisite check, extracts PLUGIN_NAME variable, simplifies README dev setup docs, and adds CRC host mapping for macOS containers. Co-Authored-By: Claude <noreply@anthropic.com>
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
A few minor remarks. Merge once they are fixed.
Good work! 👍
| exit 1 | ||
| fi | ||
|
|
||
| if ! command -v helm &>/dev/null; then |
There was a problem hiding this comment.
Move the check into build_pages.
| set -euo pipefail | ||
|
|
||
| LOG_DIR=".dev-logs" | ||
| PLUGIN_NAME="console-functions-plugin" |
There was a problem hiding this comment.
Use a local variable in build_pages, it's only used there.
| "Add pages/plugin.yaml to .gitignore so the generated file is not committed", | ||
| "Document usage in README or script header" | ||
| ], | ||
| "passes": false |
There was a problem hiding this comment.
Should be true if done -> update claude progress with that before merge.
| @@ -55,7 +55,9 @@ Available image tags are listed in the [container registry](https://github.com/f | |||
| In one terminal window, run: | |||
There was a problem hiding this comment.
Readme looks great! Thank you for the update.
I'd leave it because we have also init --stop|--randomize-ports or the init usage will be fragmented.
2 participants
Changes
@matejvasek @twoGiants is this somewhat coming closer to the idea stated above?