You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add per-repo error handling in loadFunctionTableItems so a deleted GitHub repo no longer crashes the entire list page (repos that fail to load are silently skipped)
Use function name from func.yaml instead of repo name as the correlation key, so cluster matching works when the two differ
Rename parseNamespaceAndRuntime to parseFuncYaml and extract the name field
Edit link breaks when func.yaml name differs from repo name.
The list page now uses the func.yaml name as the item name (FunctionsListPage.tsx:227: newItem(name || repo.name, ...)), and the edit link navigates using that name (FunctionsListPage.tsx:208: navigate(\/faas/edit/${name}`)`).
But resolveRepoContent in FunctionEditPage.tsx:193 looks up repos by GitHub repo name: repos.find((r) => r.name === repoName).
When func.yaml has name: my-function but the repo is named my-repo:
List page shows my-function
Clicking edit navigates to /faas/edit/my-function
resolveRepoContent searches for a repo named my-function, finds nothing
Edit page fails
The FunctionTableItem (or the edit route) needs to carry the repo name alongside the display name so that resolveRepoContent can resolve correctly.
Non-blocking
Silent error swallowing (FunctionsListPage.tsx:228-229): Bare catch drops all errors, not just 404s from deleted repos. Network timeouts and rate limits would silently hide repos with no indication to the user.
1. Edit link (blocking): Added repoName field to FunctionTableItem. The edit button now passes fn.repoName (the GitHub repo name) instead of fn.name (the func.yaml display name), so resolveRepoContent resolves correctly even when they differ. Added a test covering the divergent-name case.
2. Silent error swallowing (non-blocking): Changed the bare catch to log via console.warn with the repo name and error message, so network timeouts and rate limits are visible instead of silently dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadFunctionTableItemsso a deleted GitHub repo no longer crashes the entire list page (repos that fail to load are silently skipped)func.yamlinstead of repo name as the correlation key, so cluster matching works when the two differparseNamespaceAndRuntimetoparseFuncYamland extract thenamefieldFixes SRVOCF-840
Test plan
namediffers from repo name. List page shows the func.yaml name and matches cluster status correctly