Semana7 aula5 #28
Open
Semana7 aula5 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 19, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Oi Joao! Sua entrega foi avaliada como dentro do esperado!
Voce concluiu a algumas das funcionalidades propostas, mas faltaram alguns detalhes importantes. Queria te pedir principalmente atencao à descricao do seu PR, que deve conter as informacoes importantes sobre o projeto e link do surge. Atencao tambem na hora de nomear variavels! "PegaP" nao é um bom nome de funcao, poderia ser um pouco mais significativo, voce nao acha? Alem disso, lembre-se de criar os arquivos e as funcoes dos componentes sempre iniciando o nome com letra maiuscula!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Como relatado no projeto de ontem minha internet passou por uma manutenção massiva e ficou oscilando o dia inteiro até hoje.)