Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/teams/android/development/00_git_flow.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ In general, the PR description is optional. If you want to help your colleagues

### PR Check

Our pull requests are automatically checked by GitHub Actions to ensure code quality and convention standards. If the PR does not comply with the rules, Danger will report the issues as a comment on the related PR, so the shortcomings can be fixed.
Our pull requests are automatically checked by GitHub Actions to ensure code quality and convention standards.



Expand Down
8 changes: 1 addition & 7 deletions docs/teams/android/development/10_code_style.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,9 @@ The config file is located at `config/detekt.yml`.

Link to [current config](https://github.com/futuredapp/kmp-futured-template/blob/develop/config/detekt.yml)

### Danger

[Danger](https://danger.systems/) provides an easier way to craft Continuous Integration scripts. It runs during your CI, and automates common code review chores, hence providing additional continuous integration and enforcement of specific standards before merging any code.

Each repository should have its own `Dangerfile`, adapted to specific needs. We also apply company-wide [danger rules](https://github.com/futuredapp/danger) across all our projects. The `Dangerfile` refers to these rules.

## How to be a good developer

1. Set your Android Studio code style to the default settings - let `.editorconfig` define your IDE's formatting style.
2. Either install the KtLint IDEA plugin or run the `ktLintFormat` gradle task before making a commit.
3. When you are ready to create a PR, ensure you run the `lintCheck` gradle task first and fix any reported issues to keep the codebase clean.
4. During a PR check, the `lintCheck` gradle task is run again to catch any remaining issues, which are then reported by Danger.
4. During a PR check, the `lintCheck` gradle task is run again to catch any remaining issues.
5 changes: 0 additions & 5 deletions docs/teams/fullstack/development/00_git_flow.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,6 @@ We use a structured Git branching model to ensure smooth collaboration and maint



### Automated Checks

- **Dangerfile**
We use a Dangerfile to automatically check commit and pull request parameters, ensuring adherence to our standards.

### Release Tags

- **Version Tags**
Expand Down
2 changes: 1 addition & 1 deletion docs/teams/fullstack/development/20_code_review_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A thorough code review process helps us maintain high quality, consistency, and
Every pull request must receive at least one approving review before it can be merged.

- **Passing Checks**
All automated PR checks (CI, Dangerfile, tests, etc.) must pass before merging.
All automated PR checks (CI, tests, etc.) must pass before merging.

- **Draft PRs**
Draft pull requests are welcome for early feedback, but they are not reviewed until marked as "Ready for Review."
Expand Down
4 changes: 1 addition & 3 deletions docs/teams/ios/ios_git_flow.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,4 @@ While doing code review, be nice and respect the work of another team member. Pa

### Continuous Integration

Another required part to merge a PR is successful build on the CI. Pull request with failing build is not possible to merge. CI also sends [Danger](http://danger.systems/ruby/) report to the PR, which checks both git flow rules enforcements and code style issues. Danger rules in use on our projects are available in [futuredapp/danger]( https://github.com/futuredapp/danger/) repository.

Danger reports issues and errors. Errors must be fixed before merging the PR, issues are strongly recommended to fix.
Another required part to merge a PR is successful build on the CI. Pull request with failing build is not possible to merge.
8 changes: 0 additions & 8 deletions docs/teams/ios/ios_new_project.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,14 +276,6 @@
- add `test/test` check (for GitHub Actions)

![Step 16](Resources/ios_new_project_27.png){ width="900" }

- add `danger/danger` check (for Any source)

![Step 17](Resources/ios_new_project_28.png){ width="200" }

- added checks looks like this

![Step 18](Resources/ios_new_project_29.png){ width="500" }

6. Enjoy!

Expand Down