Fix Rate RequestOption and type-hinting#349
Fix Rate RequestOption and type-hinting#349chrom wants to merge 4 commits intogabrielbull:masterfrom
Conversation
src/Rate.php
Outdated
| * @throws Exception | ||
| */ | ||
| public function shopRates($rateRequest) | ||
| public function shopRates($rateRequest, string $requestOption = 'Rate'): RateResponse |
There was a problem hiding this comment.
Could you please add a class with all requestoption strings? (old school enum)
There was a problem hiding this comment.
If you are talking about a list of possible parameter values, then it is specified \Ups\Rate::setRequestOption in comment
There was a problem hiding this comment.
Ok but you can create kind of this class. It forces type-hinting instead of relying on pure string while we don't have a good PHPStan coverage.
final class RateRequestOption
{
public const RATE = 'Rate';
public const SHOP = 'Shop';
// ...
}and use it in function definition
|
IMHO we need add how to run phpstan for some file in example Rate.php to doc: |
|
PHPStan integration is planned but we need to have a full pass on current docblock because some classes are not up-to-date or typehint is wrong. |
2 participants
No description provided.