Repository navigation
Fix group actions and add invitation QR, preview and join dialogs - #473
Closed
m-enes-senovali wants to merge 2 commits into
Closed
m-enes-senovali wants to merge 2 commits into
m-enes-senovali wants to merge 2 commits into
Conversation
m-enes-senovali
marked this pull request as ready for review
October 12, 2026 12:12
Owner
|
Obrigado, @m-enes-senovali! O trabalho foi aprovado na revisão, com uma pequena correção na ordem de Tab do diálogo Nova conversa. Como não podemos enviar commits para o seu fork, movemos tudo para o #474, que mantém seus commits e sua autoria. Fechando este PR em favor dele. Generated by Claude Code |
gabrielhhaber
added a commit
that referenced
this pull request
Oct 12, 2026
#473) (#474) * Fix group operation outcomes and add invitation link and QR dialog * Add invitation link preview and explicit group join dialog * Keep Tab order of New chat buttons matching the visual order Move the Join group by link button into the buttons row after New contact, so Tab follows reading order. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZLyiFkKJy9STrYAhZ7NGt --------- Co-authored-by: Muhammet Enes Senovali <mesenovali@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
Collaborator
|
Thank you very much for the excellent contribution, Muhammet. Excellent fix as well, now group actions are much more robust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group actions could report success without confirming the requested memberships, close a chat after an unsuccessful leave, or lose the group ID returned by the provider. This change validates those outcomes, distinguishes membership from pending approval, and applies group editing and member-add permissions consistently across both tabs.
Group information now offers an invitation dialog with a readable/copyable link and a QR image generated from that same link. Administrators can explicitly reset the invitation after confirmation. Uncertain resets clear the previous link and QR; closed dialogs and changed connections reject late results. The invitation button waits for group metadata so the first dialog receives the confirmed administrator state.
New chat also offers Join group by link. Users paste an invitation, preview the group name, description, available member count and approval requirements, then choose to join. Only confirmed membership opens the group; pending approval stays a request. An uncertain join cannot be repeated from that dialog. Preview errors do not expose or log invitation codes, and both canonical and legacy
/invite/HTTPS links remain accepted by the API.Validation:
git diff --checkpassed.3c208a0210938745ef4eff6cb911fd323159d024: all four checks passed, including Windows (19,264 passed / 320 skipped), pip compatibility and both macOS builds. The isolated Node wrapper is skipped in CI without the vendored dependencies; its mocked local run is separate evidence. Maintainer review is still pending.No local full suite, wx GUI, WinEvent, or live WhatsApp probes were run. Installed WinZapp and real account data were not accessed. Real-provider, phone, and packaged NVDA acceptance remain outstanding. This PR is ready for maintainer review; merge and release remain separate decisions.