Skip to content

Fix group actions and add invitation QR, preview and join dialogs - #473

Closed
m-enes-senovali wants to merge 2 commits into
gabrielhhaber:mainfrom
m-enes-senovali:fix/group-invites-correctness
Closed

m-enes-senovali wants to merge 2 commits into
gabrielhhaber:mainfrom
m-enes-senovali:fix/group-invites-correctness

Conversation

@m-enes-senovali

@m-enes-senovali m-enes-senovali commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Group actions could report success without confirming the requested memberships, close a chat after an unsuccessful leave, or lose the group ID returned by the provider. This change validates those outcomes, distinguishes membership from pending approval, and applies group editing and member-add permissions consistently across both tabs.

Group information now offers an invitation dialog with a readable/copyable link and a QR image generated from that same link. Administrators can explicitly reset the invitation after confirmation. Uncertain resets clear the previous link and QR; closed dialogs and changed connections reject late results. The invitation button waits for group metadata so the first dialog receives the confirmed administrator state.

New chat also offers Join group by link. Users paste an invitation, preview the group name, description, available member count and approval requirements, then choose to join. Only confirmed membership opens the group; pending approval stays a request. An uncertain join cannot be repeated from that dialog. Preview errors do not expose or log invitation codes, and both canonical and legacy /invite/ HTTPS links remain accepted by the API.

Validation:

  • Focused serial headless Python checks passed for the affected behavior. The metadata-race delta passed 38 tests; the join and translation checks passed 86, with 23 initially blocked by sandbox temp-directory setup and then passing in a fresh workspace temp directory. These are overlapping focused runs, not a full-suite total.
  • Updated isolated Node controller tests passed with mocked providers; focused TypeScript checking reported no diagnostics.
  • All seven translation catalogs compiled and passed validation. API patch registration and git diff --check passed.
  • The required local winzapp-reviewer review approved the corrected package.
  • GitHub CI on head 3c208a0210938745ef4eff6cb911fd323159d024: all four checks passed, including Windows (19,264 passed / 320 skipped), pip compatibility and both macOS builds. The isolated Node wrapper is skipped in CI without the vendored dependencies; its mocked local run is separate evidence. Maintainer review is still pending.

No local full suite, wx GUI, WinEvent, or live WhatsApp probes were run. Installed WinZapp and real account data were not accessed. Real-provider, phone, and packaged NVDA acceptance remain outstanding. This PR is ready for maintainer review; merge and release remain separate decisions.

@m-enes-senovali m-enes-senovali changed the title Fix group operation outcomes and add invitation links and QR Fix group actions and add invitation QR, preview and join dialogs Oct 12, 2026
@m-enes-senovali
m-enes-senovali marked this pull request as ready for review October 12, 2026 12:12
Copilot AI balanced review requested due to automatic review settings October 12, 2026 12:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copy link
Copy Markdown
Owner

Obrigado, @m-enes-senovali! O trabalho foi aprovado na revisão, com uma pequena correção na ordem de Tab do diálogo Nova conversa. Como não podemos enviar commits para o seu fork, movemos tudo para o #474, que mantém seus commits e sua autoria. Fechando este PR em favor dele.


Generated by Claude Code

gabrielhhaber added a commit that referenced this pull request Oct 12, 2026
#473) (#474)

* Fix group operation outcomes and add invitation link and QR dialog

* Add invitation link preview and explicit group join dialog

* Keep Tab order of New chat buttons matching the visual order

Move the Join group by link button into the buttons row after New contact, so Tab follows reading order.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZLyiFkKJy9STrYAhZ7NGt

---------

Co-authored-by: Muhammet Enes Senovali <mesenovali@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
@gustavo-barrios2006

Copy link
Copy Markdown
Collaborator

Thank you very much for the excellent contribution, Muhammet.
It was an option that was missing in WinZapp, and now it supports it as well. Very good.

Excellent fix as well, now group actions are much more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants