Add PURE annotation to generated typedef#240
Open
skeggse wants to merge 1 commit intogajus:masterfrom
Open
Conversation
Marking this statement as pure provides a workaround for the runtime types being unused via live code inclusion/treeshaking and the disabling of function annotations.
10 tasks
Contributor
Author
|
@gajus does this seem reasonable (not a comprehensive solution but not problematic)? |
Owner
|
This solution seems fine. However, can you please add a test case (even though there are others that are failing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking this statement as pure provides a workaround for #239 via live code inclusion/treeshaking and the disabling of function annotations. For example, a rollup configuration object like this will fully prune usage of
flow-aws-lambdawithannotate: falseconfigured: