Skip to content

refactor(galacean): replace @ts-ignore with @ts-expect-error and modernize loop #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luo2430 wants to merge 1 commit into
base: dev/2.0
Choose a base branch
from
Open

refactor(galacean): replace @ts-ignore with @ts-expect-error and modernize loop #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/galacean/src/ShaderPool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ export class ShaderPool {
];

for (const source of sources) {
// @ts-ignore — `_createFromPrecompiled` is `Shader` @internal.
// @ts-expect-error — `_createFromPrecompiled` is `Shader` @internal.
Shader._createFromPrecompiled(source);
}

// Configure the particle feedback pass's transform-feedback varyings.
// The pass itself is later looked up via `Shader.find` inside
// `ParticleTransformFeedbackSimulator`, so no caching needed here.
const feedbackPass = Shader.find("Effect/ParticleFeedback").subShaders[0].passes[0];
// @ts-ignore — `_feedbackVaryings` is `ShaderPass` @internal.
// @ts-expect-error — `_feedbackVaryings` is `ShaderPass` @internal.
feedbackPass._feedbackVaryings = ["v_FeedbackPosition", "v_FeedbackVelocity"];
}
}
8 changes: 4 additions & 4 deletions packages/galacean/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as CoreObjects from "@galacean/engine-core";
import { Loader, Polyfill, SystemInfo } from "@galacean/engine-core";
import { ShaderPool } from "./ShaderPool";
//@ts-ignore

export const version = `__buildVersion`;

console.log(`Galacean Engine Version: ${version}`);
Expand All @@ -11,8 +11,8 @@ export * from "@galacean/engine-loader";
export * from "@galacean/engine-math";
export * from "@galacean/engine-rhi-webgl";

for (let key in CoreObjects) {
Loader.registerClass(key, CoreObjects[key]);
for (const [key, value] of Object.entries(CoreObjects)) {
Loader.registerClass(key, value);
}

// Bootstrap the Galacean engine flavor: browser polyfills first (must
Expand All @@ -26,7 +26,7 @@ for (let key in CoreObjects) {
// shader bundle dependency), which in turn lets the offline shader
// compiler import core's enums without dragging the full runtime closure.
Polyfill.registerPolyfill();
// @ts-ignore — `_initialize` is `SystemInfo` @internal.
// @ts-expect-error — `_initialize` is `SystemInfo` @internal.
SystemInfo._initialize();
ShaderPool.init();
ShaderPool.registerShaders();
Loading