Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/RenderPipeline/InstanceBuffer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export class InstanceBuffer {
this._intView = new Int32Array(this._data);
this.buffer?.destroy();
this.buffer = new Buffer(this._engine, BufferBindFlag.ConstantBuffer, totalBytes, BufferUsage.Dynamic);
this.buffer.isGCIgnored = true;
}
}

Expand Down
25 changes: 25 additions & 0 deletions tests/src/core/RenderPipeline/InstanceBuffer.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { WebGLEngine } from "@galacean/engine";
import { afterEach, describe, expect, it } from "vitest";

describe("InstanceBuffer", () => {
let engine: WebGLEngine | undefined;

afterEach(() => {
engine?.destroy();
engine = undefined;
});

it("keeps its engine-owned buffer alive across resource-manager garbage collection", async () => {
engine = await WebGLEngine.create({ canvas: document.createElement("canvas") });
const instanceBuffer = engine._batcherManager.instanceBuffer;
instanceBuffer.setLayout({ instanceFields: [], instanceMaxCount: 1, structSize: 16 });
const buffer = instanceBuffer.buffer;

engine.resourceManager.gc();

expect(buffer.destroyed).toBe(false);

engine._batcherManager.destroy();
expect(buffer.destroyed).toBe(true);
});
});
Loading