ci(python): pin MACOSX_DEPLOYMENT_TARGET so the cross-built x86 wheel is installable#14
Open
alvinttang wants to merge 1 commit into
Open
ci(python): pin MACOSX_DEPLOYMENT_TARGET so the cross-built x86 wheel is installable#14alvinttang wants to merge 1 commit into
alvinttang wants to merge 1 commit into
Conversation
… is installable PR #13 restored the x86_64-apple-darwin wheel by cross-building it on the Apple-silicon macos-latest runner. But the wheel's platform tag is derived from the macOS deployment target, which was unpinned — so a cross-build on a macOS 14/15 runner risks tagging the wheel macosx_14_*_x86_64. pip on an older Intel Mac would then reject that wheel and silently fall back to the sdist (compile from source), defeating the whole point of shipping the wheel. Pin an explicit floor per arch via env on the maturin step: - x86_64-apple-darwin -> 10.12 (broad Intel-Mac compatibility) - aarch64-apple-darwin -> 11.0 (Apple-silicon minimum; explicit, not host-derived) - Linux leg: matrix field absent -> env expands empty -> ignored off-macOS Follow-up to #13. Verify with the release-python workflow_dispatch dry-run before the next version tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (follow-up to #13)
#13 restored the
x86_64-apple-darwinwheel by cross-building it on the Apple-siliconmacos-latestrunner. That works, but a Python wheel carries a platform tag derived from the macOS deployment target — and it was unpinned.On a macOS 14/15 runner the cross-built x86 wheel can be tagged
macosx_14_*_x86_64. pip on an older Intel Mac then rejects that wheel and silently falls back to the sdist (compile-from-source) — defeating the entire point of shipping the wheel. A raw binary tarball (release-binary.yml) doesn't have this failure mode; a tagged wheel does.Change
Pin an explicit floor per arch, via
envon the maturin step:MACOSX_DEPLOYMENT_TARGETx86_64-apple-darwin10.12(broad Intel-Mac compatibility)aarch64-apple-darwin11.0(Apple-silicon minimum; explicit, not host-SDK-derived)Verification
release-python.ymlworkflow_dispatchrunsbuild+sdistbut notpublish(gated onrefs/tags/) — a zero-risk dry-run. Triggered onmainto confirm the cross-build itself works; this PR adds the tag pin on top. Inspect the producedwheels-x86_64-apple-darwinartifact's filename to confirm themacosx_10_12_x86_64tag before the next release tag.🤖 Generated with Claude Code