feat: enhance selector config with XPath, mask, and domain management#22
Merged
feat: enhance selector config with XPath, mask, and domain management#22
Conversation
- hideSelectors and maskSelectors now accept XPath selectors (prefix
with xpath= or start with //) in addition to CSS selectors
- Add maskSelectors config for toHaveScreenshot({mask}) to handle OOPIF
iframes; defaults include YouTube, Vimeo, Spotify, Twitter/X,
Facebook, Instagram, TikTok, Dailymotion, SoundCloud, Google Maps
- Add whitelistedDomains and blacklistedDomains to CrawlConfig, moving
hardcoded domain lists into configurable defaults
- Remove 2s waitForTimeout before toHaveScreenshot in generation.spec.ts
— OOPIF content is now masked instead of waited on
- Update manifest schema to persist new config fields
- Update init-config template with documented examples of all new options
https://claude.ai/code/session_01EvhZXE7mzjiGSevuxk1Ctb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01EvhZXE7mzjiGSevuxk1Ctb