support multiple NrMovedPoints arguments in PrimitiveGroupsIterator

[ThomasBreuer]

addresses #80

(Fortunately, NrMovedPoints was the only function that had this problem.)

[codecov]

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.16%. Comparing base (5deb588) to head (b7ebabf).

Files with missing lines	Patch %	Lines
lib/primitiv.gi	95.65%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   99.11%   99.16%   +0.04%     
==========================================
  Files          46       46              
  Lines       38323    38333      +10     
==========================================
+ Hits        37984    38012      +28     
+ Misses        339      321      -18     

Files with missing lines	Coverage Δ
lib/primitiv.gi	62.06% <95.65%> (+3.82%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ThomasBreuer]

Concerning code coverage:

If we want to see the warnings about missing degree restrictions, then we have to call PrimitiveGroupsIterator in situations where the arguments do not yield a degree restriction inside PRIMRANGE.
This means that a search over the whole library is executed, which is at least time-consuming.

Moreover, one gets an error message if the library of groups of degree larger than 4095 is not installed.
Can we assume that the groups of these degrees are available in the tests?

Turning this question around:
Would it perhaps be useful to adjust PRIMRANGE to the two possible situations that either only the small degree groups are available or also the large degree groups?

[fingolfin]

We will soon have all groups of degree < 8192 in this repo, so part of your question will become moot. I need to find some time to properly think about the rest.

BTW I think this also affects Size. E.g:

gap> List(AllIrreducibleSolvableGroups(Dimension,2,Characteristic,3,Size,8,Size,16),Size);
[ 16 ]
gap> List(AllIrreducibleSolvableGroups(Dimension,2,Characteristic,3,Size,16,Size,8),Size);
[ 8, 8, 8 ]

[ThomasBreuer]

BTW I think this also affects Size. E.g:

But this is about another function, AllIrreducibleSolvableGroups.
I was not aware of its existence.
(Well, I knew about such a function in the IrredSol package, apparently its name is AllIrreducibleSolvableMatrixGroups.)

[ThomasBreuer]

Trying to understand the background of AllIrreducibleSolvableGroups, I am getting even more irritated.
Apparently the IrredSol package provides a database of irreducible solvable matrix groups, and the PrimGrp package provides a small subset of this database.
The IrredSol manual mentions this fact, and provides functions for translating between the two sources where this makes sense.
The PrimGrp manual does not mention IrredSol at all. In fact, the manual chapter about Irreducible Matrix Groups is not even mentioned in the package overview.
(Well, currently just the Abstract of the manual would be a sensible place for that.)