Remove the irreducible solvable matrix groups - #86
Open
fingolfin wants to merge 1 commit into
Open
Conversation
lib/irredsol.g* implement a subset of what the irredsol package provides, and in worse shape: IrreducibleSolvableGroup has raised an error for years because two groups were missing from its database, and the data reaches only p^n < 256. The group counts agree with irredsol for every (n,p) in that range, its selection functions accept the same conditions, and it declares MinimalBlockDimension, IsPrimitiveMatrixGroup and DegreeOfMatrixGroup itself, so nothing there depends on these declarations. PrimitiveIndexIrreducibleSolvableGroup goes as well: it is documented in lib/primitiv.gd but keyed by the indexing that leaves with the data. CHANGES.md records what to use instead, and where the replacement is not a rename. See #83 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 99.13% 99.38% +0.24%
==========================================
Files 46 43 -3
Lines 38327 37290 -1037
==========================================
- Hits 37995 37059 -936
+ Misses 332 231 -101
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/irredsol.g* implement a subset of what the irredsol package provides, and in worse shape: IrreducibleSolvableGroup has raised an error for years because two groups were missing from its database, and the data reaches only p^n < 256.
The group counts agree with irredsol for every (n,p) in that range, its selection functions accept the same conditions, and it declares MinimalBlockDimension, IsPrimitiveMatrixGroup and DegreeOfMatrixGroup itself, so nothing there depends on these declarations.
PrimitiveIndexIrreducibleSolvableGroup goes as well: it is documented in lib/primitiv.gd but keyed by the indexing that leaves with the data.
CHANGES.md records what to use instead, and where the replacement is not a rename.
Resolves #83
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Since this is a breaking change, I think we should give more people a heads-up about this plan, so that they can speak up with concerns. I'll email the GAP mailing list.