fix(deps): pin basic-ftp to 5.3.1 to fully clear CVE-2026-39983 and 3 sibling HIGH advisories#2227
Open
time-attack wants to merge 2 commits into
Open
fix(deps): pin basic-ftp to 5.3.1 to fully clear CVE-2026-39983 and 3 sibling HIGH advisories#2227time-attack wants to merge 2 commits into
time-attack wants to merge 2 commits into
Conversation
…bling HIGH advisories basic-ftp reaches the tree only transitively: puppeteer-core > @puppeteer/browsers > proxy-agent > pac-proxy-agent > get-uri > basic-ftp Versions <= 5.3.0 carry four HIGH advisories, all fixed in 5.3.1: - GHSA-chqc-8p9q-pq6q (CVE-2026-39983) FTP command injection via CRLF - GHSA-6v7q-wjvx-w8wg incomplete CRLF protection (USER/PASS + MKD bypass) - GHSA-rpmf-866q-6p89 DoS via unbounded multiline control-response buffering - GHSA-rp42-5vxx-qpwr DoS via unbounded memory in Client.list() Pin via a bun `overrides` entry rather than a phantom direct dependency. Overriding forces every basic-ftp in the tree to 5.3.1, including get-uri's nested copy; `bun audit` then reports zero basic-ftp advisories (total 37 -> 33, HIGH 13 -> 9). A direct-dependency bump leaves get-uri/basic-ftp at the vulnerable version and audit still flags all four. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Parses package.json overrides + every resolved basic-ftp specifier in bun.lock (including nested paths like get-uri/basic-ftp) and fails if any is below 5.3.1. Deterministic and offline. Fires on the pre-fix tree (basic-ftp@5.2.0) and would also catch a direct-dependency-only bump that leaves a nested vulnerable copy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basic-ftpreaches the dependency tree only transitively:Versions ≤ 5.3.0 carry four HIGH advisories, all fixed in 5.3.1:
GHSA-chqc-8p9q-pq6q(CVE-2026-39983) — FTP command injection via CRLFGHSA-6v7q-wjvx-w8wg— incomplete CRLF protection (USER/PASS + MKD bypass)GHSA-rpmf-866q-6p89— DoS via unbounded multiline control-response bufferingGHSA-rp42-5vxx-qpwr— DoS via unbounded memory inClient.list()Fix
Pin via a bun
overridesentry so everybasic-ftpin the tree resolves to 5.3.1 (including get-uri's nested copy), rather than adding a phantom direct dependency.bun auditgoes from 4 basic-ftp HIGH advisories to 0 (repo total 37 → 33, HIGH 13 → 9). 5.3.1 stays within get-uri's^5.0.2range and avoids the 6.x major bump.Adds
test/basic-ftp-security-pin.test.ts— a deterministic, offline tripwire that fails if any resolvedbasic-ftpinbun.lock(including nested paths likeget-uri/basic-ftp) is below 5.3.1.Why this supersedes #2205
#2205 bumps
basic-ftpto 5.2.1 as a direct dependency. Verified locally: after that change, bun keepsget-uri/basic-ftp@5.2.0nested, the root 5.2.1 copy is unused (gstack imports nothing frombasic-ftp), andbun auditstill reports all four HIGH advisories unchanged. 5.2.1 would also only address 1 of the 4 (the incomplete-CRLF follow-up needs 5.2.2; the two DoS advisories need 5.3.1).Verification
bun install→ onlybasic-ftp@5.3.1in the tree;bun auditreports zero basic-ftp advisories.ftp-srv) round-trip on 5.3.1:list/downloadTo/uploadFrom/cd/pwd/sizeall work identically to 5.2.0 on legitimate paths.cd("nowhere\r\nDELE SENTINEL.txt")) that deletes a file on 5.2.0 is rejected client-side on 5.3.1 ("Contains control characters").get-uri@6.0.5fetches anftp://URI on the overridden 5.3.1 — the exact operationpac-proxy-agentperforms.🤖 Generated with Claude Code