fix(browse): preserve live daemon during busy loads#2231
Open
time-attack wants to merge 1 commit into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a heavy page load, browse could mistake a busy browser daemon for a dead one and restart it. That discarded open tabs, cookies, and logged-in sessions.
Browse now preserves an unresponsive daemon while its process is still alive and asks the user to retry. Automatic restart happens only after the daemon process is actually gone.
Technical details
Evidence
The same live CLI probe ran in five isolated baseline/candidate repo pairs:
Every baseline killed the daemon and replaced its session state. Every candidate preserved the original PID and session token.
Secondary checks
bun run buildpassedFixes #2219