fix(setup): bound Playwright bootstrap and preserve skill registration#2233
Open
time-attack wants to merge 1 commit into
Open
fix(setup): bound Playwright bootstrap and preserve skill registration#2233time-attack wants to merge 1 commit into
time-attack wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some Macs, setup could wait forever while checking or downloading Chromium. Retrying started more stuck installers, and setup stopped before registering commands such as /qa and /ship.
Setup now limits how long browser checks and downloads may run, allows only one setup at a time, cleans up timed-out child processes, and still registers commands when Chromium is unavailable.
Technical changes
Live verification
Identical baseline/candidate probes were run in isolated clones and HOME directories:
The evidence gate passed and no marked child processes remained.
Secondary tests
bash -n setupbun test test/setup-playwright-deadline.test.ts test/setup-windows-fallback.test.ts— 12 passed