fix(codex): replace dead --enable web_search_cached flag with --search#2249
Open
kinoko-studio wants to merge 1 commit into
Open
fix(codex): replace dead --enable web_search_cached flag with --search#2249kinoko-studio wants to merge 1 commit into
kinoko-studio wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
codex-cli 0.144.1 marks the web_search_cached feature deprecated (codex features list) and prints, on every invocation that still passes it: deprecated: `[features].web_search_cached` is deprecated because web search is enabled by default. Set `web_search` to "live", "indexed", "cached", or "disabled" ... in config.toml if you want to override it. Live-tested: `codex exec` with no search-related flag at all still performs real web searches successfully, so the old flag was inert (just a noisy warning), not the thing keeping search on. This PR replaces it with `--search` instead of dropping it outright, to pin live web search explicitly rather than lean on codex's implicit default — codex-cli has already changed this exact mechanism once (the old features-flag system to the new web_search config key), so an explicit flag is more robust to it changing again. Also corrects the "Web search" doc note in codex/SKILL.md(.tmpl), which described the old flag as "OpenAI's cached index" — inaccurate for --search's live lookup via the native Responses web_search tool.
4befb2b to
6e4fc11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-cli0.144.1 marksweb_search_cacheddeprecated (codex features list) and prints, on every invocation that still passes--enable web_search_cached:codex execwith no search-related flag at all still performs real web searches successfully. So the old flag wasn't keeping search on — it was just inert, printing a noisy warning on every gstack codex pass (autoplan, codex, design-consultation, design-review, document-release, office-hours, plan-ceo-review, plan-design-review, plan-devex-review, plan-eng-review, review, ship, plus twoscripts/resolvers/*.tsfiles and the.tmplcounterparts).--searchrather than dropping it outright (see Drop deprecated--enable web_search_cachedfrom codex calls #2224 for the bare-removal alternative). Rationale for the explicit flag over relying on codex's implicit default:codex-clihas already changed this exact mechanism once (the oldfeatures.web_search_cachedboolean → the newweb_searchconfig key), so pinning search on explicitly is more robust to it changing again than depending on whatever the built-in default happens to be.codex/SKILL.md(.tmpl), which described the old flag as "OpenAI's cached index" — inaccurate for--search's live lookup via the native Responsesweb_searchtool.Test plan
web_search_cachedis deprecated viacodex features listand the live stderr warning on codex-cli 0.144.1codex execperforms successful real web searches with no search flag at all (rules out "the old flag was required for search to work")grep -r "enable web_search_cached"returns zero matches post-fix--searchis present at every prior call sitebun test test/host-config.test.ts(golden-file regression) — greenbun test browse/test/ test/ make-pdf/test/ ...— exit 0bun run skill:checkclean across all host targets afterbun run gen:skill-docs --host allSupersedes #2224 (bare removal) — closing that one with this rationale.
🤖 Generated with Claude Code