fix: resilient two-phase setup — skills install without bun/Playwright#683
Open
jteng wants to merge 2 commits intogarrytan:mainfrom
Open
fix: resilient two-phase setup — skills install without bun/Playwright#683jteng wants to merge 2 commits intogarrytan:mainfrom
jteng wants to merge 2 commits intogarrytan:mainfrom
Conversation
…wright Restructure setup into Phase 1 (skill linking, zero deps beyond bash+git) and Phase 2 (browse build + Playwright, requires bun). Phase 1 always runs first so Claude skills are linked on any system. Phase 2 failures produce warnings, not exits. Adds unified summary at end. - Convert fatal bun check to conditional HAS_BUN flag - Move skill linking before browse build - Guard Codex/Factory linking on .agents/.factory directory existence - Guard Kiro browse symlinks on browse/dist existence - Wrap Phase 2 in set +e / set -e for error tolerance - Add 8 structural tests for phase ordering and resilience Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflict in setup: keep resilient two-phase approach (HAS_BUN flag) while incorporating upstream's security-hardened bun install instructions with checksum verification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./setupinto Phase 1 (skill linking — zero deps beyond bash+git) and Phase 2 (browse build + Playwright — requires bun)What changed
HAS_BUNflag.agents//.factory/directory existencebrowse/distexistenceset +e/set -efor error toleranceTest plan
bun testpasses (633 tests, 0 failures)./setupwithout bun → links Claude skills, warns about rest, no fatal exit./setupwith bun but Playwright fails → noexit 1in browse build or Playwright sections./setupnormally → identical behavior to current, plus unified summary🤖 Generated with Claude Code