fix: use jq for JSON field stripping in telemetry sync (#710)#717
Closed
stedfn wants to merge 1 commit intogarrytan:mainfrom
Closed
fix: use jq for JSON field stripping in telemetry sync (#710)#717stedfn wants to merge 1 commit intogarrytan:mainfrom
stedfn wants to merge 1 commit intogarrytan:mainfrom
Conversation
sed regex breaks on escaped quotes and commas in JSON values. Use jq when available for correct JSON manipulation, keeping sed as a fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
Owner
|
Closing — overlaps with #749 which addresses the same issue. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jq -c 'del(...)'for correct JSON field removal whenjqis availablesedregex as a fallback for environments withoutjqFixes #710
Test plan
jqinstalled: verify telemetry sync strips fields correctlyjqabsent: verify sed fallback still works for simple JSON🤖 Generated with Claude Code