fix: pass extraEnv to Windows server launcher#719
Open
jeffrichley wants to merge 1 commit intogarrytan:mainfrom
Open
fix: pass extraEnv to Windows server launcher#719jeffrichley wants to merge 1 commit intogarrytan:mainfrom
jeffrichley wants to merge 1 commit intogarrytan:mainfrom
Conversation
The Windows code path in startServer() used Node's child_process.spawn with detached:true for process independence, but only forwarded BROWSE_STATE_FILE to the spawned process. The extraEnv parameter (containing BROWSE_HEADED, BROWSE_PORT, BROWSE_SIDEBAR_CHAT) was silently dropped, causing /connect-chrome to always launch headless on Windows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startServer()was silently droppingextraEnv(containingBROWSE_HEADED,BROWSE_PORT,BROWSE_SIDEBAR_CHAT), causing/connect-chrometo always launch headless on WindowsBROWSE_STATE_FILEto the spawned process; theextraEnvparameter was ignoredObject.assignRoot cause
cli.ts:235-239— the Windows code path builds a one-liner JS string to spawn the server vianode -e. Theenvobject in that string only includedBROWSE_STATE_FILE, not theextraEnvparameter passed by callers like theconnectcommand.The macOS/Linux path (line 243) correctly passes
...extraEnvviaBun.spawn().Test plan
/connect-chromenow opens a visible headed Chromium windowextraEnvconsumers work (e.g.BROWSE_PORTforwarding)🤖 Generated with Claude Code