Add review artifact persistence and user overlay mechanism#721
Open
Focus695 wants to merge 1 commit intogarrytan:mainfrom
Open
Add review artifact persistence and user overlay mechanism#721Focus695 wants to merge 1 commit intogarrytan:mainfrom
Focus695 wants to merge 1 commit intogarrytan:mainfrom
Conversation
Two changes to improve gstack's persistence across sessions and upgrades:
1. plan-eng-review: Auto-persist full review findings to
~/.gstack/projects/{slug}/eng-reviews/ as markdown. Future
sessions can recover context without re-running the review.
2. gstack-upgrade: Add user overlay step after ./setup completes.
Copies files from ~/.gstack/user-overlay/<skill-name>/ over the
freshly-upgraded skill directory, preserving user customizations
that would otherwise be lost to git reset --hard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.gstack/projects/{slug}/eng-reviews/as markdown. Future sessions can recover context without re-running the review. The file includes all issues (P0-P3), user decisions, architecture diagrams, test coverage diagrams, and implementation order../setupcompletes. Copies files from~/.gstack/user-overlay/<skill-name>/over the freshly-upgraded skill directory, preserving user customizations that would otherwise be lost togit reset --hard.What problem does this solve?
Lost review context: After
/plan-eng-reviewcompletes, the detailed findings only exist in the JSONL metadata log and the conversation. If the session ends, all the structured findings (issues, decisions, diagrams) are gone. This PR writes a persistent markdown file that future sessions can read.Updates destroy customizations:
gstack-upgradeusesgit reset --hard origin/main+./setup, which destroys any local edits users made to skill files. The user overlay mechanism (~/.gstack/user-overlay/) gives users a safe place to store their customizations that survive upgrades.Files changed
plan-eng-review/SKILL.md.tmpl+ generatedSKILL.md— adds "Review Artifact" sectiongstack-upgrade/SKILL.md.tmpl+ generatedSKILL.md— adds "Step 4.5: Apply user overlay" (existing vendored sync moved to Step 4.6)Test plan
/plan-eng-reviewand verify~/.gstack/projects/{slug}/eng-reviews/gets a markdown file~/.gstack/user-overlay/plan-eng-review/SKILL.md.tmpl, run/gstack-upgrade, verify overlay is appliedbun run gen:skill-docsto confirm regeneration is clean