fix(report): a tally is not a verdict, and "1 device(s)" is not a sentence - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML report is written for someone who did not run the tool - a housemate, a landlord, whoever administers the router. Its headline was
192.168.1.0/24 - 6 info: subnet notation that reader does not read, and a count of a severity level they have never heard of. It also made "nothing needs doing" and "act today" look like the same kind of statement, which are the two furthest-apart things in the document.(s)markers no longer reach a reader. A rule cannot know its own count, so the templates keep the marker andpluraliseresolves it infinding(), where the count is finally known - across all five fields, including theevidencethe rules build with the same marker.1 service(s) ... are bound,1 other device(s) ... are reachable). Reworded to read at any count rather than teaching the helper about verbs.Rule prose is untouched.