Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audit --explain RULEexplains a finding. This explains the vocabulary a finding is written in - "the router answered an unauthenticated control request" only lands on someone who already knows what UPnP is, and the people this tool helps most are exactly the ones who do not.netdiff glossarylists 30 terms, one line each;netdiff glossary upnpprints the whole entry with see-also links. Unknown term exits 2 and names the known ones, same shape as--explain.print_fieldfor wrapping - no new rendering code. The tests pin the structure, not the prose: a see-also link pointing at nothing is the only thing here that can be wrong rather than merely badly worded.Two unrelated fixes found by an earlier audit, folded in as a second commit:
findingsdropped a row it should have kept. A TCP and a UDP forward on the same external port produce identical rule/device/title, so the primary key collapsed them - the audit the database recorded was not the audit that was printed. Evidence carries the protocol, so it joins the key._decode_txttruncated whereparse_recordsbails. A TXT string claiming to be longer than its rdata gavemodel=Mac, a confident wrong answer where no answer is the honest outcome.