Repository navigation
Start every test scratch folder empty - #22
Merged
Merged
Conversation
The folders were named after the test process's id and never emptied. Windows reuses process ids, and on 2026-10-17 a run found an earlier run's session marker and edge files: five engine scenarios failed on a docs-only branch. One shared helper now empties the folder first, in place of eight copies of which only one did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each test scratch folder was named after the test process id and never emptied. Windows reuses process ids, so on 2026-10-17 a run picked up an earlier run's session marker and edge files, and five engine scenarios failed on a docs-only branch.
One shared helper,
crate::testing::fresh_dir, now empties the folder first. It replaces eight copies, of which only one emptied its folder. This needs to be reliable before Lot 20 lets CI gate automatic merges.build.ps1 testpasses.🤖 Generated with Claude Code