feat(cardComponenent): adds a large cardComponent for single object view#35
Open
sandragjacinto wants to merge 1 commit intomasterfrom
Open
feat(cardComponenent): adds a large cardComponent for single object view#35sandragjacinto wants to merge 1 commit intomasterfrom
sandragjacinto wants to merge 1 commit intomasterfrom
Conversation
sandragjacinto
force-pushed
the
card-component
branch
2 times, most recently
from
4d72c14 to
7df4221
Compare
sandragjacinto
force-pushed
the
card-component
branch
from
7df4221 to
f83de68
Compare
hpierre74
reviewed
Jan 19, 2020
Member
There was a problem hiding this comment.
Idk, in a way it's cool to customise an existing element and make it look "totally" different. On the other side this is way more complex to understand (the abstraction with wrapper, the mapping ...)
What do you think ? Does it worth it to create a new component ? How much would we want to customise it in the future ? @sandragjacinto
hpierre74
approved these changes
Jan 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a large cardComponent for single object view
maybe overkill ? @hpierre74