Preserve provider reasoning and Codex summaries in buffered responses - #120
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jmlago
marked this pull request as ready for review
September 21, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffered responses discarded reasoning fields returned by providers, preventing downstream agents from capturing their complete response. Preserve provider-exposed reasoning and usage in buffered chat, including stream-backed aggregation, and retain Codex summaries and opaque reasoning items in chat and Responses output.
Validation: 152 focused tests passed locally, including empty-response/deadline regressions and reconstruction of the actual
/v1/responsesSSE output. Full CI on4c2364b: 1,131 Python tests passed (2 skipped), 729 core tests passed, and both images built with startup/import smoke checks passing. CI run. Branch includes current main and the PR119 probability-rounding fix.Scope: upstream providers are mocked in tests; no live provider/OAuth request or deployment performed. Public chat reasoning deltas, native non-compatible adapters and downstream trace persistence remain outside this change. Compatible SSE reasoning-details fragments are preserved as received; failed Codex streams may still discard partial summaries. This preserves only provider-exposed data, not hidden internal reasoning.
Rollback: revert this PR; no database or configuration migration.
Summary by CodeRabbit
New Features
Documentation