PB-1383: Typescript+Pinia migration #1420
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-PB-1383-pinia-store
branch
5 times, most recently
from
69171a7 to
bdd5620
Compare
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
3 times, most recently
from
448f1a4 to
2393419
Compare
web-mapviewer
|
|||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1383-pinia-store
|
| Run status |
|
| Run duration | 19m 41s |
| Commit |
|
| Committer | Felix Sommer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
39
|
Flaky
|
0
|
Pending
|
19
|
Skipped
|
0
|
Passing
|
138
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
drawing.cy.ts • 14 failed tests • e2e/chrome/mobile
| Test | Artifacts | ||
|---|---|---|---|
| The first 10 failed tests are shown, see all 14 tests in Cypress Cloud. | |||
The first 5 failed specs are shown, see all 19 specs in Cypress Cloud.
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
from
fc5442f to
639f478
Compare
PB-1383: Migrate Script
…ests-pinia PB-2040: migrate cypress tests pinia
that will then be used to describe KML/GPX/COG layers cleaning up a bit the layers type def, removing duplicates, and switching all comments to JSDoc
Issue : When loading the print menu for the first time, the scales and the background preview of the layout would not show. Toggling the print menu would then show the scales and the background preview instead of closing the menu, and the menu would then work as intended. Cause : When toggling the menu for the first time, we wanted to set a watcher within the toggle menu function which would catch when the print layouts changed to load the layouts and select one. This managed to not fire as intended, and simultaneously shortcut the already existing watcher, resulting in a state where the menu was open, but not considered to be open, which meant the scales would not be computed. Fix: We keep loading the layouts if they are not loaded, but we no longer wait on a watcher that's not firing up to show the menu.
- Issue: When going through the points, we skipped the last segment, and fixed its time to 0. This was spotted by user @aronsommer . - Fix: We no longer skip the last segment
…n-hikingTime PB-2052: Fix off by one error in hiking Time function
simplifying a bit the useFieldValidation composable, and trying to maintain reactivity of props given there, even if it is two components down (EmailInput calls TextInput which calls useFieldValidation)
removing most bi-directional links and having all the "config" in one big catch'em all bag
Some props need to be transformed to ref so that the composable doesn't loose the reactivity on them. Also changing the logic of the userFieldValidation "pristin" flag, to clarify what it was meant for (and removing its usage whenever the default behavior was the one in place)
watchEffect will be called whenever the composable is set up, and then each time one of the props is changed (so the onMounted hook will create a double unnecessary call)
PB-2064: reportproblem cypress
PB-2064: Rearrange header tests to make it clearer and less redundant.
in prepration for further modules/packages that will require access to this information. Also moving all "constants" that are not environment-related to the staging-config package, only keeping those that will change depending on the VITE_ENV/staging of the viewer
PB-1387: move Theme/Style/SCSS elements to a dedicated theme module
…s-not-defined PB-2064: Fix missing process is not defined.
also moving there GPX/KML utils, and legacy param utils, as they are used by some API files
Moving Vitest CLI "flags" found in package json files into the config itself
and especially Vitest, as there is in v4.0.9+ a fix for the pooling of threads, which fails sporadically on the CI. Locking Vite in version v7.2.2, as upgrading further breaks the build with unplugin-dts. Unplugin-dts has been in the same "beta" version for the last 6 month, we should maybe look for an alternative if it stays like that too long
since switching to the version 1.2.0, the manifest for the PWA has slightly increased, reaching the limit of 5MB. I've pushed it to 7MB to keep the build from failing because of that.
looks like it could fix the issue that is present on the CI with video recording (takes forever)
PB-1387: all API files as a package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link