web: consume @bb/shared-ui for button/input/label - #1954
Open
yegor-korobeynikov wants to merge 3 commits into
Open
web: consume @bb/shared-ui for button/input/label#1954yegor-korobeynikov wants to merge 3 commits into
yegor-korobeynikov wants to merge 3 commits into
Conversation
update_environment_directory switches a thread's environment/cwd for the next turn but never invalidated the last recorded provider session. The provider CLI keys its own session storage by the cwd it started in, so resuming that session id under a new cwd fails with "No conversation found with session ID: ...". getLastStoredProviderThreadId now withholds a session for resume when its recorded environmentId explicitly differs from the thread's current one, letting the next turn start a fresh provider session instead. A missing environmentId (legacy/synthetic rows) still falls back to the old trusting behavior.
Zero importers anywhere in apps/web — confirmed via grep. Leftover from the original copy-paste fork of shared-ui; @bb/shared-ui already provides these if apps/web ever needs them.
apps/web had its own copy-pasted button/input/label components, byte-identical to shared-ui's, differing only in import paths. Adds @bb/shared-ui as a dependency, wires the Tailwind v4 @source scan so its classes are not purged from the prod bundle, ports the four theme.css tokens shared-ui needs that apps/web did not yet define (success-foreground, surface-recessed-soft-solid, surface-raised-solid, surface-attention), swaps dashboard.tsx's imports to the shared package, and removes the now-dead local copies. landing.css's separate ink-prefixed token set is untouched - the landing/dashboard token-isolation boundary in __root.tsx still holds.
yegor-korobeynikov
force-pushed
the
design-system/web-shared-ui-migration
branch
from
August 20, 2026 18:50
5ce28bc to
7a98c0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web(the public site, getbb.app) had its own copy-pastedbutton/input/labelcomponents — byte-identical in logic topackages/shared-ui's, diverging only in import paths. This swapsapps/web'sdashboard.tsxonto@bb/shared-uiand removes the now-dead local copies (plus already-unusedbadge/pill/card).badge.tsx,pill.tsx,card.tsx(zero importers)@bb/shared-uias a dependency ofapps/web@sourcescan directive so shared-ui's classes aren't purged from the prod bundle (mirrorsapps/app's theme.css)apps/webdidn't yet define (--success-foreground,--surface-recessed-soft-solid,--surface-raised-solid,--surface-attention) —landing.css's separate token set and the landing/dashboard isolation boundary in__root.tsxare untoucheddashboard.tsx's imports to@bb/shared-ui/button,@bb/shared-ui/input,@bb/shared-ui/labelbutton.tsx,input.tsx,label.tsxTest plan
pnpm --filter @bb/web typecheck— cleanpnpm --filter @bb/web test— 13 files / 74 tests passpnpm --filter @bb/web build— succeeds; verified compiled CSS bundle contains shared-ui's classes and all four new tokens (not purged)vite dev+ headless-browser check of/dashboardand/(landing) — both render correctly, computed styles resolve to real color values (novar(--undefined)fallbacks), no console errorsvibecodethis.site) — not verified: the staging Worker requires 5 secrets (GITHUB_CLIENT_ID,GITHUB_CLIENT_SECRET,BETTER_AUTH_SECRET,LANDING_POSTHOG_KEY,RESEND_API_KEY) that weren't available in this environment. The localvite devcheck above covers rendering/CSS but not the real Worker runtime or auth flow — flagging this as a known, named gap for a maintainer with staging secrets to confirm before merge, not a silent skip.