Fix main: drop the removed claudeCodeMockCliTraffic experiment from mobile - #1995
Merged
Conversation
…obile #1993 removed the experiment key from @bb/domain while #1988 (the mobile app) was in flight, so main fails @bb/mobile typecheck: the Experiments screen still lists the key, and the Phase 7 e2e reset script still PUTs it (the experiments record is exhaustive, so the request would 400). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
#1993 removed the
claudeCodeMockCliTrafficexperiment key from@bb/domainwhile #1988 (the mobile app) was in flight. After both merged,mainfails@bb/mobiletypecheck:apps/mobile/src/screens/settings/ExperimentsSettingsScreen.tsxstill lists the key, andapps/mobile/e2e/scripts/phase7-settings-reset.jsstill PUTs it to/api/v1/settings/experiments(the experiments record is exhaustive under zod 4, so the reset would 400 and the nightly Mobile E2E would fail).What changed
How you verified
pnpm exec turbo run typecheck lint test --filter=@bb/mobileonmain+ this change: all green (119 test files). Typecheck fails onmainwithout it.git grep claudeCodeMockCliTrafficleaves only historical migration/test references.